Smart select: only add line ranges if they’re contained by the next range #73850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm - I will merge and add a test (needs some test suite changes) |
|
thanks! |
jrieken
added a commit
that referenced
this pull request
May 24, 2019
|
🎉 Thanks @jrieken! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue described here: microsoft/TypeScript#29071 (comment) (using typescript@master—PR was just merged today)
Before:
After:
I was looking to add a test in smartSelect.test.ts, but I'm not sure how to replicate this scenario in a test environment—whatever default set of SelectionRangeProviders that are registered in those tests don’t seem to produce ranges that exhibit the issue. I'm happy to add a test if someone can provide guidance on how I can set one up.