Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new explorerViewer sort order configuration item, barrelFirst #73930

Closed
wants to merge 2 commits into from
Closed

Adds a new explorerViewer sort order configuration item, barrelFirst #73930

wants to merge 2 commits into from

Conversation

AmbrosiaDevelopments
Copy link

This setting sorts barrel files (index.js, index.ts, etc.) in alphabetical order above all other files. Folders remain above all files including barrel files.

Partially addresses #27286 (still open but not specifically calling for this) and a comment requesting this feature on a now closed issue, #12345.

… This setting sorts barrel files (index.js, index.ts, etc.) in alphabetical order above all other files. Folders remain above all files including barrel files.
@msftclas
Copy link

msftclas commented May 18, 2019

CLA assistant check
All CLA requirements met.

@sbatten sbatten requested a review from isidorn May 20, 2019 07:41
@sbatten sbatten removed the request for review from isidorn May 20, 2019 07:41
@isidorn
Copy link
Contributor

isidorn commented May 23, 2019

Thanks for this PR. However it is usually great to first start a discussion before imlpementing the whole PR.
We will not accept this since this is very javascript specific and not a lot of users requested for this.
Leaving this open as we might change our mind in the future. Thanks

@isidorn isidorn added this to the Backlog milestone May 23, 2019
@AmbrosiaDevelopments
Copy link
Author

That's fair enough. It doesn't specifically look at file extensions like .ts or .js, just any file starting with index. Would you be able to advise if this functionality (changing file explorer sort order) is possible from an extension? I have looked for how to achieve it but found nothing at all so far about changing file explorer like that.

@isidorn
Copy link
Contributor

isidorn commented May 23, 2019

Unfortunetely this is not possible using an extension. And that is one of the reason why I will keep this PR open for now, since there is no other way to achieve this.

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Oct 14, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 14, 2019

Clossing as out of scope.
Thank you again for your PR.

@isidorn isidorn closed this Oct 14, 2019
@AmbrosiaDevelopments
Copy link
Author

Is there another way to achieve this yet? Is there a plan to open up API to allow this or anything further?

@isidorn
Copy link
Contributor

isidorn commented Oct 17, 2019

There is currently no way to achieve this. We do not plan to open up the API.
There is this feature request which you can comment on and upvote #27286

@AlanLeeMoven
Copy link

Recommend changing 'barrel' to 'index' in every use across this PR to make the name more intuitive and specific. Hoping this gets resolved some day...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants