-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spelling of the example abbreviation (e.g.) #74785
Conversation
By the way, I'm not making this change spuriously; My original goal was to propose a change one of these messages (the one in src/vs/workbench/contrib/markers/browser/messages.ts), to make it clearer and more explicit, like this: -"Filter. Eg: text, **/*.ts, !**/node_modules/**");
+"Filter files. E.g.: text, **/*.ts, !**/node_modules/**"); but didn't want to change the "Eg." to "E.g." in one place while leaving the others in an inconsistent state. |
The files under src\typings are copied in, and shouldn't be changed since the changes will get overwritten. |
Thanks for the careful review, @alexr00. I'll fix and update the PR shortly. Edit: updated and rebased on latest master branch. |
Most of the instances of this abbreviation already use the e.g. form. This commit changes the non-conforming ones to match.
1978e5b
to
c79ea88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@alexr00 thanks for the quick merge :) for future reference, was the extended message in this specific commit not particularly useful, or is there some guideline to not add additional details to commit messages? |
Concise details are always welcome! |
Most of the instances of this abbreviation already use the "e.g." form.
This commit changes the non-conforming ones to match.
Note that although this commit changes 29 files, almost all of these changes are in code comments. The only user-visible ones are in the README, and in localizable strings on the following six files: