Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Recent list in dock does not show recent files/folders #74788 #75108

Merged
merged 11 commits into from
Jun 12, 2019

Conversation

malingyan2017
Copy link
Contributor

macOS only shows recent list with max number based on sytem config. It takes bottom n entries from the list added through Electron app.addRecentDocument. To match macOS dock recent list with VSCode internal recent list, this change add items into macOS recent document list in reverse order of internal recent list.

…74788

macOS only shows recent list with max number based on sytem config. It takes bottom n entries from the list added through Electron app.addRecentDocument. To match macOS dock recent list with VSCode internal recent list, this change add items into macOS recent document list in reverse order of internal recent list.
@msftclas
Copy link

msftclas commented Jun 8, 2019

CLA assistant check
All CLA requirements met.

@bpasero bpasero self-assigned this Jun 8, 2019
@bpasero bpasero added this to the On Deck milestone Jun 8, 2019
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented here: #74788 (comment)

I think this approach is not resolving it properly.

@bpasero bpasero modified the milestones: On Deck, June 2019 Jun 9, 2019
@bpasero bpasero merged commit 39947c7 into microsoft:master Jun 12, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants