Delete breadcrumbs.filterOnType unused setting. #75971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how that relates to #755969 |
jeanp413
commented
Jun 25, 2019
| @@ -129,13 +125,6 @@ export abstract class BreadcrumbsPicker { | |||
| this._layout(); | |||
| })); | |||
|
|
|||
| // filter on type: state | |||
| const cfgFilterOnType = BreadcrumbsConfig.FilterOnType.bindTo(this._configurationService); | |||
| this._tree.updateOptions({ filterOnType: cfgFilterOnType.getValue() }); | |||
There was a problem hiding this comment.
This overrides the setting workbench.list.keyboardNavigation and because breadcrumbs.filterOnType is commented its value is undefined/false, so the BreadcrumbsPicker tree won't filter on type after a launch/reload unless the TypeFilterController widget of the tree is clicked which modifes the filterOnType setting
jrieken
approved these changes
Jun 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75969. Maybe #55004 should be closed too.