-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-75259 - Interact with files in search results #76828
Conversation
That command will try to get the currently selected row and it will probably be trying to get it from the explorer view, not the search view. You will probably need a new command that can get the current file from the search view. |
@roblourens , Yes i figured it out and changed it accordingly . |
@roblourens , All the changes are done :) |
But does it do the right thing for a folder? |
@roblourens , sorry forgot to add that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@roblourens , I added "Reveal in Side Bar" menu to search to fix #75259 but there seems to be one issue .
When I use "Reveal in Side Bar" from the title then it switches to explorer and highlights the correct file in explorer .
I have added the same way but when I click on the new menu option I added in search , it takes me to the explorer but highlights the file that is shown in the editor and not the one I asked to Reveal in side bar.
Added a small video of the same for better understanding , Can you please help me out on this ? ( If some other event is causing the highlighting on click or something ?? )