-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for "whiteSpace" typo: Parameter name and word is one command word spelled "whitespace". #77758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
reviewed
Jul 22, 2019
I undid the unnecessary style changes. Thank you. |
mjbvz
reviewed
Jul 23, 2019
This reverts commit e590441f02830d48b72549d6013a0ee7e9c645cd.
This reverts commit c73be7bed2a818a8252519f449b23af6c5c5b2fd.
This reverts commit 58fe37a91fc099f0205cda6e7423c303d810b243.
This reverts commit 4b3e76abc170276a160f3d86ab424e9a40523d7d.
This reverts commit 41697f62ab0ed562164121024b95b1baabd64e7e.
This reverts commit d60b16c82e3ab83d6b1f2787a176d5a2e38b829b.
Are these changes appropriate, or are there any changes I need to fix? |
It looks like there are still refactoring changes in |
ghost
commented
Jul 24, 2019
Made changes! |
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browsing the vscode source, I noticed there is a misspelling of the word "whitespace", where the variable/property names were "whiteSpace". I noticed that this could have huge consequences, as the property "renderWhitespace" has no capital s, but in the commonEditorConfig, the property name has a capital s. As a result, I replaced "whiteSpace" variable names to "whitespace".
I did this by searching and replacing all instances of "whiteSpace" and "WhiteSpace" to "whitespace" and "Whitespace" respectively. There was one comment that was an incomplete sentence regarding one of the whitespace functions, so I fixed that as well.
Finally, I was able to reduce the code in PathCompletion regarding whitespace handling. The code has the same behavior, and passed the automated and smoke tests.
I hope this proves useful in the long run!