Use pty naming instead of virtual process #77961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabeDeBacker
approved these changes
Jul 26, 2019
src/vs/vscode.proposed.d.ts
Outdated
| * The callback used to execute the task. Cancellation should be handled using | ||
| * [Pseudoterminal.shutdown](#Pseudoterminal.shutdown). When the task is complete, | ||
| * [Pseudoterminal.onDidExit](#Pseudoterminal.onDidExit) should be fired with the exit code | ||
| * with '0' for success and a non-zero value for failure. |
There was a problem hiding this comment.
Are negative numbers allowed? If not,m can we comment that here as well.
There was a problem hiding this comment.
This part hasn't changed in this PR, though I'm leaning towards just making this an Event<void> though and letting the extension show a notification if that's what it wants to do when it fails.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #77160