Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase 'For' in 'Checking For Updates...' menu item #77972

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Lowercase 'For' in 'Checking For Updates...' menu item #77972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/platform/menubar/electron-main/menubar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ export class Menubar {
})];

case StateType.CheckingForUpdates:
return [new MenuItem({ label: nls.localize('miCheckingForUpdates', "Checking For Updates..."), enabled: false })];
return [new MenuItem({ label: nls.localize('miCheckingForUpdates', "Checking for Updates..."), enabled: false })];

case StateType.AvailableForDownload:
return [new MenuItem({
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/browser/parts/titlebar/menubarControl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ export class CustomMenubarControl extends MenubarControl {
this.updateService.checkForUpdates({ windowId }));

case StateType.CheckingForUpdates:
return new Action('update.checking', nls.localize('checkingForUpdates', "Checking For Updates..."), undefined, false);
return new Action('update.checking', nls.localize('checkingForUpdates', "Checking for Updates..."), undefined, false);

case StateType.AvailableForDownload:
return new Action('update.downloadNow', nls.localize({ key: 'download now', comment: ['&& denotes a mnemonic'] }, "D&&ownload Now"), undefined, true, () =>
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/update/electron-browser/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ export class UpdateContribution extends Disposable implements IWorkbenchContribu
group: '5_update',
command: {
id: 'update.checking',
title: nls.localize('checkingForUpdates', "Checking For Updates..."),
title: nls.localize('checkingForUpdates', "Checking for Updates..."),
precondition: FalseContext
},
when: CONTEXT_UPDATE_STATE.isEqualTo(StateType.CheckingForUpdates)
Expand Down