Fix global linting and for in errors #79551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydresser
commented
Aug 21, 2019
build/gulpfile.hygiene.js
Outdated
| @@ -199,7 +199,7 @@ gulp.task('tslint', () => { | |||
| .pipe(filter(tslintExtensionsFilter)) | |||
| .pipe(gulptslint.default({ rulesDirectory: 'build/lib/tslint' })) | |||
| .pipe(gulptslint.default.report({ emitError: true })) | |||
| ]); | |||
| ]).pipe(es.through()); | |||
There was a problem hiding this comment.
Added this since the gulp task was failing when no errors were being thrown. It still seems to fail correctly when actual errors occur.
|
Some more context on this PR, after finding the tslint was working on window, I found this is a os specific issue. On linux, if I run But on windows works fine. With this branch, both linux and windows work. |
|
Thanks. I meanwhile pushed a change to disable the rules in code, I guess that is why we see merge conflicts now. Thanks for the gulp file fix, that I already took over to |
# Conflicts: # src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts # src/vs/workbench/contrib/tasks/common/tasks.ts
|
@bpasero Sounds good, I'll close this since it seems like its not necessary anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed #79222 was added but the rules weren't actually being applied (apparently because of the casing of the files). There were also some
for inerrors still in the code.There were a couple files that linting said shouldn't be accessing some globals but were so I added exceptions for them, not sure if that's actually correct though.