Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #80014 #80071

Merged
merged 1 commit into from
Sep 2, 2019
Merged

fixes #80014 #80071

merged 1 commit into from
Sep 2, 2019

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Aug 29, 2019

No description provided.

@dgozman dgozman marked this pull request as ready for review August 29, 2019 20:47
@dgozman
Copy link
Contributor Author

dgozman commented Aug 29, 2019

@isidorn Could you please take a look? This is my first PR to vscode, so any contributing suggestions are more than welcome!

@isidorn isidorn added this to the September 2019 milestone Aug 30, 2019
@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2019

@dgozman thanks a lot for providing a PR. This looks great and captures the approach I had in mind. I left one minor comment inline in the code.
Did you build vscode with these changes and verifed that #80014 gets fixed?

dgozman
dgozman commented Aug 30, 2019
View reviewed changes
Copy link
Contributor Author

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you build vscode with these changes and verifed that #80014 gets fixed?
Sure, my repro case works as expected with this change.

src/vs/workbench/contrib/debug/common/debug.ts Outdated Show resolved Hide resolved
@isidorn
Copy link
Contributor

isidorn commented Sep 2, 2019

Looks great, thanks a lot for this PR.
Merging in 🎉

@isidorn isidorn merged commit 55bec33 into microsoft:master Sep 2, 2019
@dgozman
Copy link
Contributor Author

dgozman commented Sep 3, 2019

Thank you!

@anthonydresser anthonydresser mentioned this pull request Sep 13, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isidorn isidorn isidorn requested changes

Assignees

@isidorn isidorn

Labels
None yet
Projects
None yet
Milestone
September 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@dgozman @isidorn