Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Press space key on a disabled button should not trig click event. #81975

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Press space key on a disabled button should not trig click event. #81975

merged 1 commit into from
Oct 5, 2019

Conversation

youngyou
Copy link
Contributor

@youngyou youngyou commented Oct 4, 2019

Press space key on a disabled button should not trig click event.

@youngyou
Update button.ts
a46c17e 
Press `space` key on a disabled button should not trig click event
Tyriar
Tyriar approved these changes Oct 5, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 👍

@Tyriar Tyriar added this to the October 2019 milestone Oct 5, 2019
@Tyriar Tyriar merged commit ff09b48 into microsoft:master Oct 5, 2019
@Tyriar Tyriar self-assigned this Oct 5, 2019
@youngyou youngyou deleted the patch-1 branch October 5, 2019 04:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@youngyou @Tyriar