Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out dead keys in tree keyboard navigation #82972

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Filter out dead keys in tree keyboard navigation #82972

merged 1 commit into from
Oct 21, 2019

Conversation

frobinsonj
Copy link
Contributor

Fixes #80741

Steps to reproduce original issue:

  1. Set keyboard layout to Portuguese
  2. Put focus on explorer section
  3. Press one of the following keys:
  • ^
  • ´
  • `
  • ~

This PR should prevent these key presses from outputting 'Dead' in the tree keyboard navigation.

@joaomoreno joaomoreno merged commit cfb88f2 into microsoft:master Oct 21, 2019
@joaomoreno
Copy link
Member

Thanks! 🍻

@joaomoreno joaomoreno added this to the October 2019 milestone Oct 21, 2019
@joaomoreno joaomoreno added the tree-widget Tree widget issues label Oct 21, 2019
@frobinsonj frobinsonj deleted the fix-80741 branch October 22, 2019 12:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@joaomoreno joaomoreno

Labels
tree-widget Tree widget issues
Projects
None yet
Milestone
October 2019
Development

Successfully merging this pull request may close these issues.

Press BracketLeft to find in explorer and shows Dead
2 participants
@frobinsonj @joaomoreno