Adopt icon font in activity bar #83113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidorn
requested changes
Oct 23, 2019
|
@misolori thanks for this PR. I have tried it out and it works great. The only conern I have I left a comment in the code directly. We should not reference the names of viewlets in any way, since this is a complete hack. I am aslo not sure why is this needed? Maybe you can explain the issue. |
isidorn
reviewed
Oct 23, 2019
|
@isidorn let me know if this is good to merge in. Later on I can work on seeing if we can add some type of |
|
Yes, this is better now and we can merge. Thanks a lot |
isidorn
approved these changes
Oct 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #78889
This adopts the icon font in the activity bar for our primary views:
Extensions can still use custom icons and there are no visual changes:
cc @bpasero @sandy081