Use the editor font size for the breakpoint widget #83153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, the breakpoint widget doesn't respect the `editor.fontSize` setting. It always has the default font size even the user has increased the font size for the editor. Modified `breakpointWidget.ts` to set the `fontSize` option as per the setting. Also, fixed the centering of the input by calculating the top margin of the input container dynamically: > `topMargin = (heightOfContainer - lineHeight * numLines) / 2`
isidorn
requested changes
Oct 23, 2019
|
@anirudhrb thank you very much for your PR. |
isidorn
added
the
debug
1. Removed an extra call to centerInputVertically() 2. Removed the margin-top css rule for inputContainer since it is no longer required
|
Looks good, thanks for this PR! ☀️ ☀️ ☀️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the breakpoint widget doesn't respect the
editor.fontSizesetting. It always has the default font size even the user has increased the
font size for the editor. Modified
breakpointWidget.tsto set thefontSizeoption as per the setting.Also fixed the centering of the input by calculating the top margin of the
input container dynamically:
Tested by increasing the editor font size in settings and verified that the
breakpoint widget respects it. Also tested that a change in the setting
reflects dynamically without having to re-open the widget.
Fixes #78790