Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use appendArgument to add switch values #84320

Merged
merged 2 commits into from
Nov 11, 2019
Merged

fix: don't use appendArgument to add switch values #84320

merged 2 commits into from
Nov 11, 2019

Conversation

deepak1556
Copy link
Collaborator

The api electron uses for the appendArgument call doesn't actually work with switch values https://cs.chromium.org/chromium/src/base/command_line.h?l=200-204

@deepak1556 deepak1556 self-assigned this Nov 8, 2019
@deepak1556 deepak1556 added this to the November 2019 milestone Nov 8, 2019
@bpasero bpasero mentioned this pull request Nov 11, 2019
Closed
@deepak1556 deepak1556 merged commit 2c79231 into master Nov 11, 2019
@deepak1556 deepak1556 deleted the robo/fix_append_args branch November 11, 2019 17:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@deepak1556 @bpasero