Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve explorer compressed nodes behavior #84782

Merged
merged 31 commits into from
Nov 15, 2019
Merged

Improve explorer compressed nodes behavior #84782

merged 31 commits into from
Nov 15, 2019

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Nov 14, 2019 •
edited
Loading

This PR fixes #84597

We want to support the following use cases on a compressed folder row:

  • Context clicking each folder
    • Add multiple name support for IconLabel @joaomoreno
    • Add multiple name highlight support for IconLabel @joaomoreno
    • Improve context affordance, make sure the user knows which folder they are right clicking @joaomoreno
    • Allow commands to reach into compressed context @isidorn
  • Keyboard navigation among compressed folders @joaomoreno
  • Multiple selection should always pick all the folders in a compresed row @isidorn
  • Dragging each folder @joaomoreno
  • Dropping into each folder @joaomoreno
  • Rename @joaomoreno

@joaomoreno joaomoreno self-assigned this Nov 14, 2019
@joaomoreno joaomoreno added this to the November 2019 milestone Nov 14, 2019
@joaomoreno joaomoreno added the file-explorer Explorer widget issues label Nov 14, 2019
joaomoreno and others added 23 commits November 14, 2019 10:01
@joaomoreno
fix multiple name highlights in iconlabel
075a6bb
@joaomoreno
Merge remote-tracking branch 'origin/master' into joao/explorer-compr…
8667883 
…essed-tree
@joaomoreno
explorer: show active folder
f0d2d02
@joaomoreno
💄
e2d22b5
@joaomoreno
cleanup
70df257
@joaomoreno
wip: explorer compressed navigation controller
f538270
@joaomoreno
async data tree: fix missing disposeCompressedElements
768252a
@joaomoreno
explorer: compressed navigation home and end
b1ac958
@joaomoreno
💄
4d05b4d
@joaomoreno
fade out separators
a0a2c5a
@joaomoreno
types
875c0fc
@joaomoreno
compressed explorer: drag from
bc53eaa
@isidorn
explorer: actions should get context from explorerService
5db10f8
@isidorn
explorer: respect compressed navigation controller
e96805a
@joaomoreno
wip: explorer compressed dnd
e7b543b
@joaomoreno
explorer dnd ignore last
ecfe31c
@joaomoreno
remove console.log
27f7b4e
@joaomoreno
💄
9d99383
@joaomoreno
list, tree: dnd.onDragEnd
fb5144b
@joaomoreno
💄
e8afb2e
@joaomoreno
remove unused method
ae4e530
@joaomoreno
list, tree: allow no feedback
0385a69
@joaomoreno
allow dropping into compressed folders
0a9681f
@joaomoreno joaomoreno merged commit 77e0ee9 into master Nov 15, 2019
@joaomoreno joaomoreno deleted the joao/explorer-compressed-tree branch November 15, 2019 19:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@joaomoreno joaomoreno

Labels
file-explorer Explorer widget issues
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.

Explorer: Improve compressed folder actions
2 participants
@joaomoreno @isidorn