Port UI #85603
Merged
Port UI #85603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjbvz would you like to keep ownership of the Tunnel Service? I talked to Alex D, and if you don't want it then I would take it over. If you do want to keep it, could you review the tunnel service related files 😊? |
|
@alexr00 It's all yours. I only owned it because the webview was the first consumer of tunnels |
mjbvz
approved these changes
Nov 26, 2019
src/vs/workbench/services/remote/common/remoteExplorerService.ts
Outdated
Show resolved
Hide resolved
alexr00
force-pushed
the
alexr00/PortUI
branch
from
5b3fbdf to
8d5e4fe
Compare
|
Thank you for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/vscode-remote-release#1777