Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ports not unforwarding #86594

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Fix ports not unforwarding #86594

merged 1 commit into from
Dec 10, 2019
+3 −1

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Dec 9, 2019

Fixes #86074

@alexr00 alexr00 added this to the November 2019 milestone Dec 9, 2019
@alexr00 alexr00 self-assigned this Dec 9, 2019
@alexr00 alexr00 requested a review from alexdima December 9, 2019 14:54
alexdima
alexdima approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra explanation @alexr00. It looks like the dispose function is recursive and in the second call the else is hit which really disposes the tunnel... This is super complex IMHO.

@alexr00 alexr00 merged commit 835a113 into release/1.41 Dec 10, 2019
@alexr00 alexr00 deleted the alexr00/portsUnForwarding branch December 10, 2019 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@alexr00 @alexdima