Tree Guide Indents not showing in latest Insiders #86675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking into this... |
joaomoreno
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
Oh I see what's happening here. There's a common list stylesheet, but treeIndentGuidesStroke happens to be the only tree-only style... and we do not have a common tree stylesheet. Let's merge this in and I'll follow up with #86680
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86662
WIth the commit 75a778d we have accidently broke the indent guide styling in the tree. We were doing
attachStylerinstead ofattachListStylerwhich takes into account the default list options. WIthout it the indent guides would remain transparent.I have verified that this PR fixes the issue for me.
@bpasero can you please verify
Also adding @joaomoreno in case he take a peek while he is on vacation