-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add call hierarchy support for TypeScript 3.8 #88168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this!
The main change is that we can't bundle TS 3.8 with VS Code yet. Instead, let's just copy over the new TS types related to call hierarchy and keep using the TS 3.7 for everything else
extensions/typescript-language-features/src/utils/typeConverters.ts
Outdated
Show resolved
Hide resolved
🕺 this is soo exciting |
I'll update the PR shortly, that's actually how I had it set up before creating the PR. |
8f9908f
to
870edea
Compare
Thanks! We'll ship VS Code 1.42 with support for call hierarchy support but users will still need to update to TS 3.8 Once we pick up TS 3.8 with VS code 1.43, it will be available to everyone. I'll also remove the copied over protocol types at that point |
This adds Call Hierarchy support for TypeScript 3.8 and is the other half of microsoft/TypeScript#35176.
Related: #16110, microsoft/TypeScript#31863
cc: @mjbvz, @jrieken