Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call hierarchy support for TypeScript 3.8 #88168

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Jan 6, 2020

This adds Call Hierarchy support for TypeScript 3.8 and is the other half of microsoft/TypeScript#35176.

Related: #16110, microsoft/TypeScript#31863

cc: @mjbvz, @jrieken

Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!

The main change is that we can't bundle TS 3.8 with VS Code yet. Instead, let's just copy over the new TS types related to call hierarchy and keep using the TS 3.7 for everything else

@jrieken
Copy link
Member

jrieken commented Jan 7, 2020

🕺 this is soo exciting

@rbuckton
Copy link
Member Author

rbuckton commented Jan 7, 2020

We only ship stable TS versions in stable VS Code. That means that we can't update this until TS 3.8 is released in mid February.

I'll update the PR shortly, that's actually how I had it set up before creating the PR.

@rbuckton rbuckton force-pushed the typescriptCallHierarchy branch from 8f9908f to 870edea Compare January 8, 2020 20:34
@mjbvz mjbvz merged commit 71b60d0 into microsoft:master Jan 8, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 8, 2020

Thanks! We'll ship VS Code 1.42 with support for call hierarchy support but users will still need to update to TS 3.8

Once we pick up TS 3.8 with VS code 1.43, it will be available to everyone. I'll also remove the copied over protocol types at that point

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants