Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git: Keep original message format on amend #89664

Closed
wants to merge 1 commit into from
Closed

Git: Keep original message format on amend #89664

wants to merge 1 commit into from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jan 29, 2020

Show only the subject line in the input box, and if it hasn't
been changed, keep the existing message.

Fixes #40295

Show only the subject line in the input box, and if it hasn't
been changed, keep the existing message.

Fixes #40295
@joaomoreno joaomoreno self-assigned this Jan 30, 2020
@joaomoreno joaomoreno added the git GIT issues label Jan 30, 2020
@orgads
Copy link
Contributor Author

orgads commented Jan 30, 2020

The test failure is unrelated to my change. Also failed on #89660

@AgainPsychoX
Copy link

AgainPsychoX commented Mar 5, 2020

I really want it to be fixed soon :C

@EliSnow
Copy link

EliSnow commented Mar 20, 2020

@joaomoreno, it would be nice to get this merged and the issue fixed

@domoritz
Copy link

I don't think this really fixed the issue, right? What if I have a multiline message and want to edit the whole message? Imho, the right fix is to use a multiline input.

@orgads
Copy link
Contributor Author

orgads commented Mar 28, 2020

Right. This is a partial fix. It should cover the most common use-case, when amend is used for the content of the commit, leaving the commit message untouched.

I don't know how to use multiline input in this context.

@orgads
Copy link
Contributor Author

orgads commented May 17, 2020

Superseded

@orgads orgads closed this May 17, 2020
@domoritz
Copy link

By #98042

@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit amend loses multiline format in commit message
5 participants