Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mouse-keyboard event crossover to prevent menu bar from showing up after multi-selecting. #9154

Merged
merged 2 commits into from
Aug 15, 2016
Merged

Add mouse-keyboard event crossover to prevent menu bar from showing up after multi-selecting. #9154

merged 2 commits into from
Aug 15, 2016

Conversation

be5invis
Copy link
Contributor

This PR adds a crossover between keyboard events and mouse events, and can successfully prevent the menu bar from showing up when multi-selecting, while not affecting existing “single-alt-press” or keyboard shortcut combinations.

@be5invis be5invis mentioned this pull request Jul 12, 2016
Closed
@be5invis be5invis changed the title Add mouse-keyboard crossover to prevent menu bar from showing up. Add mouse-keyboard event crossover to prevent menu bar from showing up after multi-selecting. Jul 12, 2016
@be5invis
Copy link
Contributor Author

be5invis commented Jul 15, 2016 •
edited
Loading

@alexandrudima Did I do anything wrong?
Currently there is no existing mechanism for crossovering mouse and keyboard events, so I have to implement it in a “direct” way...

@alexdima alexdima mentioned this pull request Aug 8, 2016
Closed
@alexdima alexdima merged commit 1c2097b into microsoft:master Aug 15, 2016
alexdima added a commit that referenced this pull request Aug 15, 2016
@alexdima
Merge pull request #9154 from be5invis/master
101ad8c
@alexdima alexdima added this to the August 2016 milestone Aug 15, 2016
@alexdima
Copy link
Member

alexdima commented Aug 15, 2016 •
edited
Loading

@be5invis Thank you for the contribution!

I extracted the code out of the editor's view (editor core logic) and into an editor contribution -- 101ad8c.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
August 2016
Development

Successfully merging this pull request may close these issues.
3 participants
@be5invis @alexdima @msftclas