Workbench editor renames #91943
Merged
Workbench editor renames #91943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* IVisibleEditor => IVisibleEditorPane * ITextEditor => ITextEditorPane * ITextDiffEditor => ITextDiffEditorPane
* IEditorService#activeControl => activeEditorPane * IEditorService#visibleControls => visibleEditorPanes
* activeTextEditorWidget => activeTextEditorControl * visibleTextEditorWidgets => visibleTextEditorControls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the following to make workbench editors easier to distinguish from our code editor:
IEditor=>IEditorPaneIVisibleEditor=>IVisibleEditorPaneITextEditor=>ITextEditorPaneITextDiffEditor=>ITextDiffEditorPaneIEditorService#activeControl=>IEditorService#activeEditorPaneIEditorService#visibleControls=>IEditorService#visibleEditorPanesactiveTextEditorWidget=>activeTextEditorControlvisibleTextEditorWidgets=>visibleTextEditorControlsThis now means that the access to the actual
controlis consistent:IEditorPane#getControl()IEditorService#activeControl/IEditorService#visibleControlsNothing changed with regards to the controls, they are still
IEditororIDiffEditor. We cannot easily bring inICodeEditoras it lives inbrowserand editor service is used in manycommonplaces.//cc @jrieken
//cc @rebornix