Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create new guid for crash reporter #92180

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

deepak1556
Copy link
Collaborator

This id should never be sent to telemetry for GDPR reasons, hence we don't reuse any of existing
persistent ids like instanceId etc.

/cc @bpasero

@deepak1556 deepak1556 added the candidate Issue identified as probable candidate for fixing in the next release label Mar 6, 2020
@deepak1556 deepak1556 added this to the February 2020 milestone Mar 6, 2020
@deepak1556 deepak1556 requested a review from sbatten March 6, 2020 21:29
@deepak1556 deepak1556 self-assigned this Mar 6, 2020
@deepak1556 deepak1556 force-pushed the robo/fix_crashreporter_metadata branch from e2f9746 to 013b8f2 Compare March 6, 2020 22:42
This id should never be sent to telemetry for
GDPR reasons, hence we don't reuse any of existing
persistent ids like instanceId etc.
@deepak1556 deepak1556 force-pushed the robo/fix_crashreporter_metadata branch from 013b8f2 to 0304821 Compare March 6, 2020 22:43
@deepak1556 deepak1556 merged commit 5996fb8 into release/1.43 Mar 6, 2020
@deepak1556 deepak1556 deleted the robo/fix_crashreporter_metadata branch March 6, 2020 22:50
@bpasero
Copy link
Member

bpasero commented Mar 7, 2020

Don't forget to get this to master.

deepak1556 added a commit that referenced this pull request Mar 9, 2020
This id should never be sent to telemetry for
GDPR reasons, hence we don't reuse any of existing
persistent ids like instanceId etc.
deepak1556 added a commit that referenced this pull request Mar 9, 2020
* feat: update appcenter config (#92041)

* fix: order of crash reporter initialization (#92044)

* fix: create new guid for crash reporter (#92180)

This id should never be sent to telemetry for
GDPR reasons, hence we don't reuse any of existing
persistent ids like instanceId etc.

* chore: update distro
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants