Drag and Drop for Global Awareness #92299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbatten
commented
Mar 18, 2020
| margin-bottom: -3px; | ||
| } | ||
|
|
||
| /* .monaco-workbench .activitybar > .content :not(.monaco-menu) > .monaco-action-bar .action-item.insertAfter { |
sbatten
commented
Mar 18, 2020
| opacity: 0; | ||
| top: 0; | ||
| pointer-events: none; | ||
| /* z-index: 1; */ |
sbatten
commented
Mar 18, 2020
|
|
||
| CompositeDragAndDropObserver.INSTANCE.registerTarget(this.element, { | ||
| onDragStart: e => { | ||
| // this.element.style.outline = `1px solid`; |
sandy081
approved these changes
Mar 18, 2020
4 tasks
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafting out what it should look like and testing its application
I think the observer should support registering participants (elements that can be dragged and register a set of callbacks) and listeners (just a set of callbacks for listening to global drag start and end).
Participants may need to listen to both their drag start event and others', should they be separate callbacks or should the participant handle checking?
We can also probably group the view id and type logic into the observer so it is responsible for populating and unpopulating the LocalTransferData