drag&drop a VSIX file on the extensions viewlet #94152
Conversation
|
Tagging @joaomoreno and @sandy081 for review. Thanks! |
|
I have updated the pull request to get rid of the code duplication (onDrop will invoke the existing install VSIX action), as well as I have fixed a bug due to which the |
|
@lszomoru Thanks for the PR. I will take a look and get back to you. BTW I updated the branch to make it easy for me to try out. |
| @@ -431,6 +438,44 @@ export class ExtensionsViewPaneContainer extends ViewPaneContainer implements IE | |||
| } | |||
| })); | |||
|
|
|||
| // Register DragAndDrop support | |||
| this._register(new DragAndDropObserver(this.root, { | |||
There was a problem hiding this comment.
Shall we have drop overlay only on extensions views excluding the search box ?
There was a problem hiding this comment.
Based on my conversation with @joaomoreno, we wanted to keep things simple and that is why we are set up the drop target/drop overlay to be the shown on the whole extensions view. If you feel strongly about this, or there is a prior pattern not to show the drop overlay over the search box, I am happy to update it.
src/vs/workbench/contrib/extensions/browser/extensionsViewlet.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/extensions/browser/extensionsActions.ts
Outdated
Show resolved
Hide resolved
Thanks for fixing this. Just to let you know there is a general bug that extension views do not get updated automatically when an extension is modified. |
@sandy081, do you have a link to the issue? Happy to take a look at it and submit a PR with the fix. |
Here is the issue - #67603 |
|
@sandy081, I think you forgot this |
|
Looks like |
|
@sandy081, fixed up the pull request to revert the changes that were not in scope. Thanks for the feedback. |
|
Abandoning the PR since my fork got into a funky state. Will re-create it from a clean fork. |
|
@joaomoreno nopes. Waiting for changes and discussing with @lszomoru over slack. |
|
I have resubmitted these changes in a new pull request - #96907 |
This PR fixes #12090
Add the capability to drag&drop a VSIX file on the extensions viewlet and have it installed. While there is still room for improvement as well as some code duplication that I would like to explore removing, I want to get some early feedback on these changes. Thanks!