File operation events support multiple resources

[pfongkye]

This PR fixes #98309

Hi @bpasero
I made some changes. Can you tell me if I'm on the right track?
If I am, I will continue with the following:

• add support move/copy multiple resources in workingCopyFileService (wcfs)
• add support delete multiple resources in wcfs
• support for onWillRunFileOperation in wcfs
• support for onDidRunFileOperation in wcfs?
• adoption in explorerViewer
• adoption in fileActions?
  - [ ] adoption in bulkEditService?
• add tests if any
• come up with a better name than UriComponentsPair?
• check if it fixes given repro

Let me know if there is anything missing on the above list.
Thanks.

[bpasero]

@jrieken for this code change that touches the extension side of things.

@pfongkye in your list I am not sure you are aware that changes have to go into the working copy file service too, which is the main service used from e.g. the explorer when you move files.

[pfongkye]

Indeed, I'll make the necessary changes in working copy file service also. Added to the list above. Thanks for the feedback.

[bpasero]

One quick feedback that I noticed, I think it is fine to have just one method in the working copy file service that accepts an array instead of having a move and moveMany method.

[pfongkye]

Yes. I was thinking the same thing.

[pfongkye]

I think the PR is ready for review. I still need to work on supporting onDidRunFileOperation though.

[pfongkye]

Btw I think we can support the same operations for delete also. What do you think?

For the bulkEdit, I'm not sure if options.overwrite will be the same for all the resources.

[bpasero]

@pfongkye I had a quick look and think you are on the right path. Once you think this PR is ready for review, I would add maybe also Isidor to review the changes for where this needs to be adopted (file explorer land).

Yes, I think for consistency I would also do this for delete 👍

[bpasero]

Assigning some folks to review:

• @jrieken for changes in ext host and bulk edit
• @isidorn for the adoption in explorer land (file actions, explorer)
• me for the working copy changes

[bpasero]

I feel that maybe the file operations inside workingCopyFileService should run in sequence and not in parallel to reduce the chance of overlapping file system operations? I think that would also make the code cleaner.

[bpasero]

Thanks 👍