Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if adapter is null and let it print errors #9966

Merged
merged 3 commits into from
Aug 3, 2016

Conversation

Meai1
Copy link
Contributor

@Meai1 Meai1 commented Jul 30, 2016

I had entire sections in the package.json missing and the errors I was getting were not helpful at all, it just said "e.adapter.variables undefined". Well it's undefined because the adapter is null!
If we work around that null we can get actually helpful messages here.

I had entire sections in the package.json missing and the errors I was getting were not helpful at all, it just said "e.adapter.variables undefined". Well it's undefined because the adapter is null!
If we work around that null we can get actually helpful messages here.
@msftclas
Copy link

Hi @Meai1, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@kieferrm kieferrm added the debug Debug viewlet, configurations, breakpoints, adapter issues label Aug 2, 2016
@weinand weinand assigned isidorn and unassigned weinand Aug 2, 2016
@isidorn isidorn added this to the August 2016 milestone Aug 2, 2016
@isidorn
Copy link
Contributor

isidorn commented Aug 2, 2016

@Meai1 thanks for the PR! Please squash your commits to be one and by our code style convention we do not use the var keyword, please use let instead.
Also did you build vscode off your changes and quickly verify that debugging works?

@Meai1
Copy link
Contributor Author

Meai1 commented Aug 3, 2016

i dont really know how git works, i just edited the file on github. I tested this by editing the unminified version of the workspace javascript file because I couldnt get the build to work, i made a separate issue for that. (#9961)

@isidorn
Copy link
Contributor

isidorn commented Aug 3, 2016

Then please address my other concern that you are using var instead of let if you would like this PR to be merged. Then I can test it.

@isidorn isidorn merged commit 30c71c5 into microsoft:master Aug 3, 2016
@isidorn
Copy link
Contributor

isidorn commented Aug 3, 2016

Looks good to me, I merged it in.
Thanks 🍻

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants