Add noprogress parameter to disable progress indicator (#2117)

* Add noprogress parameter to disable progress indicator * Add test for setting noprogress parameter
microsoft · Aug 8, 2019 · 03cb97c · 03cb97c
1 parent 2d36ed9
commit 03cb97c
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/src/vstest.console/Internal/ConsoleLogger.cs b/src/vstest.console/Internal/ConsoleLogger.cs
@@ -55,6 +55,11 @@ internal class ConsoleLogger : ITestLoggerWithParameters
         /// </summary>
         internal static bool AppendPrefix;
 
+        /// <summary>
+        /// Bool to decide whether progress indicator should be disabled.
+        /// </summary>
+        internal static bool DisableProgress;
+
         /// <summary>
         /// Uri used to uniquely identify the console logger.
         /// </summary>
@@ -75,6 +80,11 @@ internal class ConsoleLogger : ITestLoggerWithParameters
         /// </summary>
         public const string PrefixParam = "prefix";
 
+        /// <summary>
+        /// Parameter for disabling progress
+        /// </summary>
+        public const string NoProgressParam = "noprogress";
+
         #endregion
 
         internal enum Verbosity
@@ -166,7 +176,7 @@ public void Initialize(TestLoggerEvents events, string testRunDirectory)
                 ConsoleLogger.Output = ConsoleOutput.Instance;
             }
 
-            if (this.progressIndicator == null && !Console.IsOutputRedirected)
+            if (this.progressIndicator == null && !Console.IsOutputRedirected && !DisableProgress)
             {
                 // Progress indicator needs to be displayed only for cli experience.
                 this.progressIndicator = new ProgressIndicator(Output, new ConsoleHelper());
@@ -209,6 +219,12 @@ public void Initialize(TestLoggerEvents events, Dictionary<string, string> param
                 bool.TryParse(prefix, out AppendPrefix);
             }
 
+            var noprogressExists = parameters.TryGetValue(ConsoleLogger.NoProgressParam, out string noprogress);
+            if (noprogressExists)
+            {
+                bool.TryParse(noprogress, out DisableProgress);
+            }
+
             Initialize(events, String.Empty);
         }
         #endregion

diff --git a/test/vstest.console.UnitTests/Internal/ConsoleLoggerTests.cs b/test/vstest.console.UnitTests/Internal/ConsoleLoggerTests.cs
@@ -128,6 +128,21 @@ public void InitializeWithParametersShouldSetPrefixValue()
             ConsoleLogger.AppendPrefix = false;
         }
 
+        [TestMethod]
+        public void InitializeWithParametersShouldSetNoProgress()
+        {
+            var parameters = new Dictionary<string, string>();
+
+            Assert.IsFalse(ConsoleLogger.DisableProgress);
+
+            parameters.Add("noprogress", "true");
+            this.consoleLogger.Initialize(new Mock<TestLoggerEvents>().Object, parameters);
+
+            Assert.IsTrue(ConsoleLogger.DisableProgress);
+
+            ConsoleLogger.DisableProgress = false;
+        }
+
         [TestMethod]
         public void TestMessageHandlerShouldThrowExceptionIfEventArgsIsNull()
         {