Made telemetry data constants true constants (#3416)

microsoft · Mar 3, 2022 · 7e16306 · 7e16306
1 parent 81c415f
commit 7e16306
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 104 deletions.
diff --git a/src/Microsoft.TestPlatform.Common/Friends.cs b/src/Microsoft.TestPlatform.Common/Friends.cs
@@ -27,5 +27,6 @@
 [assembly: InternalsVisibleTo("Microsoft.TestPlatform.TestUtilities, PublicKey=002400000480000094000000060200000024000052534131000400000100010007d1fa57c4aed9f0a32e84aa0faefd0de9e8fd6aec8f87fb03766c834c99921eb23be79ad9d5dcc1dd9ad236132102900b723cf980957fc4e177108fc607774f29e8320e92ea05ece4e821c0a5efe8f1645c4c0c93c1ab99285d622caa652c1dfad63d745d6f2de5f17e5eaf0fc4963d261c8a12436518206dc093344d5ad293")]
 [assembly: InternalsVisibleTo("Microsoft.TestPlatform.AcceptanceTests, PublicKey=002400000480000094000000060200000024000052534131000400000100010007d1fa57c4aed9f0a32e84aa0faefd0de9e8fd6aec8f87fb03766c834c99921eb23be79ad9d5dcc1dd9ad236132102900b723cf980957fc4e177108fc607774f29e8320e92ea05ece4e821c0a5efe8f1645c4c0c93c1ab99285d622caa652c1dfad63d745d6f2de5f17e5eaf0fc4963d261c8a12436518206dc093344d5ad293")]
 [assembly: InternalsVisibleTo("vstest.ProgrammerTests, PublicKey=002400000480000094000000060200000024000052534131000400000100010007d1fa57c4aed9f0a32e84aa0faefd0de9e8fd6aec8f87fb03766c834c99921eb23be79ad9d5dcc1dd9ad236132102900b723cf980957fc4e177108fc607774f29e8320e92ea05ece4e821c0a5efe8f1645c4c0c93c1ab99285d622caa652c1dfad63d745d6f2de5f17e5eaf0fc4963d261c8a12436518206dc093344d5ad293")]
+[assembly: InternalsVisibleTo("TranslationLayer.UnitTests, PublicKey=002400000480000094000000060200000024000052534131000400000100010007d1fa57c4aed9f0a32e84aa0faefd0de9e8fd6aec8f87fb03766c834c99921eb23be79ad9d5dcc1dd9ad236132102900b723cf980957fc4e177108fc607774f29e8320e92ea05ece4e821c0a5efe8f1645c4c0c93c1ab99285d622caa652c1dfad63d745d6f2de5f17e5eaf0fc4963d261c8a12436518206dc093344d5ad293")]
 
 #endregion
diff --git a/src/Microsoft.TestPlatform.Common/PublicAPI/PublicAPI.Shipped.txt b/src/Microsoft.TestPlatform.Common/PublicAPI/PublicAPI.Shipped.txt
@@ -129,7 +129,6 @@ Microsoft.VisualStudio.TestPlatform.Common.Telemetry.NoOpMetricsCollection
 Microsoft.VisualStudio.TestPlatform.Common.Telemetry.NoOpMetricsCollection.Add(string message, object value) -> void
 Microsoft.VisualStudio.TestPlatform.Common.Telemetry.NoOpMetricsCollection.Metrics.get -> System.Collections.Generic.IDictionary<string, object>
 Microsoft.VisualStudio.TestPlatform.Common.Telemetry.NoOpMetricsCollection.NoOpMetricsCollection() -> void
-Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants
 Microsoft.VisualStudio.TestPlatform.Common.TestPlatformConstants
 Microsoft.VisualStudio.TestPlatform.Common.TestPlatformDefaults
 Microsoft.VisualStudio.TestPlatform.Common.Utilities.AssemblyProperties
@@ -238,49 +237,6 @@ static Microsoft.VisualStudio.TestPlatform.Common.Hosting.TestRuntimeProviderMan
 static Microsoft.VisualStudio.TestPlatform.Common.SettingsProvider.SettingsProviderExtensionManager.Create() -> Microsoft.VisualStudio.TestPlatform.Common.SettingsProvider.SettingsProviderExtensionManager
 static Microsoft.VisualStudio.TestPlatform.Common.SettingsProvider.SettingsProviderExtensionManager.Destroy() -> void
 static Microsoft.VisualStudio.TestPlatform.Common.SettingsProvider.SettingsProviderExtensionManager.LoadAndInitializeAllExtensions(bool shouldThrowOnError) -> void
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.AttachmentsProcessingState -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.CommandLineSwitches -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.DataCollectorsEnabled -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.DisableAppDomain -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.DiscoveryState -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.LegacySettingPrefix -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.LoggerUsed -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.MaxCPUcount -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.NumberOfAdapterDiscoveredDuringDiscovery -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.NumberOfAdapterDiscoveredDuringExecution -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.NumberOfAdapterUsedToDiscoverTests -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.NumberOfAdapterUsedToRunTests -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.NumberOfAttachmentsAfterProcessing -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.NumberOfAttachmentsSentForProcessing -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.NumberOfSourcesSentForDiscovery -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.NumberOfSourcesSentForRun -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.ParallelEnabledDuringDiscovery -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.ParallelEnabledDuringExecution -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.ParallelEnabledDuringStartTestSession -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.RunState -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.StartTestSessionCompleteEvent -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TargetDevice -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TargetFramework -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TargetOS -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TargetPlatform -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TestAttachmentsProcessingCompleteEvent -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TestDiscoveryCompleteEvent -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TestExecutionCompleteEvent -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TestPlatformVersion -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TestSettingsUsed -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TimeTakenByAllAdaptersInSec -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TimeTakenInSecByAllAdapters -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TimeTakenInSecForAttachmentsProcessing -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TimeTakenInSecForDiscovery -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TimeTakenInSecForRun -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TimeTakenToDiscoverTestsByAnAdapter -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TimeTakenToLoadAdaptersInSec -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TimeTakenToRunTestsByAnAdapter -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TotalTestsByAdapter -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TotalTestsDiscovered -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TotalTestsRanByAdapter -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TotalTestsRun -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TotalTestsRunByMSTestv1 -> string
 static Microsoft.VisualStudio.TestPlatform.Common.Utilities.CancellationTokenExtensions.ThrowTestPlatformExceptionIfCancellationRequested(this System.Threading.CancellationToken token) -> void
 static Microsoft.VisualStudio.TestPlatform.Common.Utilities.ExceptionUtilities.GetExceptionMessage(System.Exception exception) -> string
 static Microsoft.VisualStudio.TestPlatform.Common.Utilities.FakesUtilities.GenerateFakesSettingsForRunConfiguration(string[] sources, string runSettingsXml) -> string

diff --git a/src/Microsoft.TestPlatform.Common/PublicAPI/PublicAPI.Unshipped.txt b/src/Microsoft.TestPlatform.Common/PublicAPI/PublicAPI.Unshipped.txt
@@ -1,9 +1,3 @@
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TestSessionId -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TestSessionSpawnedTesthostCount -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TestSessionTesthostSpawnTimeInSec -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TestSessionState -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.TestSessionTotalSessionTimeInSec -> string
-static Microsoft.VisualStudio.TestPlatform.Common.Telemetry.TelemetryDataConstants.StopTestSessionCompleteEvent -> string
 Microsoft.VisualStudio.TestPlatform.ObjectModel.Engine.IProxyTestSessionManager.StartSession(Microsoft.VisualStudio.TestPlatform.ObjectModel.Client.ITestSessionEventsHandler eventsHandler, Microsoft.VisualStudio.TestPlatform.ObjectModel.Client.IRequestData requestData) -> bool
 Microsoft.VisualStudio.TestPlatform.ObjectModel.Engine.IProxyTestSessionManager.StopSession(Microsoft.VisualStudio.TestPlatform.ObjectModel.Client.IRequestData requestData) -> bool
 Microsoft.VisualStudio.TestPlatform.ObjectModel.Engine.IParallelProxyDiscoveryManager.IsAbortRequested.get -> bool