Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable parameters for ProcDump #2219

Closed
mihaipetroniuandrei opened this issue Oct 8, 2019 · 1 comment · Fixed by #3957
Closed

Configurable parameters for ProcDump #2219

mihaipetroniuandrei opened this issue Oct 8, 2019 · 1 comment · Fixed by #3957
Labels
enhancement needs-triage This item should be discussed in the next triage meeting. up-for-grabs

Comments

@mihaipetroniuandrei
Copy link

Description

Currently, ProcDumpArgsBuilder.cs contains some hardcoded parameters for ProcDump:

StringBuilder procDumpArgument = new StringBuilder("-accepteula -e 1 -g -t ");

and here:

We'd like to have these parameters wholly configurable through .runsettings to fit our needs.
For example, we'd like to be able to disable First Chance exceptions, to avoid unnecessary dumps for handled ACCESS_VIOLATION exceptions (weird, but it happens when working with unreliable libraries).

Steps to reproduce

Create a test that randomly throws ACCESS_VIOLATION but has _try/_except guards to catch it.

Expected behavior

BlameDataCollector has options to disable ProcDump First Chance and avoid creating a dump.

Actual behavior

The run creates a dump.

@ShreyasRmsft
Copy link
Member

@mihaipetroniuandrei we would welcome contributions and would provide any assistance needed to contribute.

@Evangelink Evangelink added the needs-triage This item should be discussed in the next triage meeting. label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs-triage This item should be discussed in the next triage meeting. up-for-grabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants