Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using arm64 in TargetPlatform node in RunSettings throws #2566

Closed
nohwnd opened this issue Sep 11, 2020 · 5 comments · Fixed by #3100
Closed

Using arm64 in TargetPlatform node in RunSettings throws #2566

nohwnd opened this issue Sep 11, 2020 · 5 comments · Fixed by #3100

Comments

@nohwnd
Copy link
Member

nohwnd commented Sep 11, 2020

Description

Originally posted here dotnet/runtime#42017

Forcing the <TargetPlatform>arm64</TargetPlatform> to arm64 will fail with:

Settings file provided does not conform to required format. An error occurred while loading the settings. Error: Invalid setting 'RunConfiguration'. Invalid value 'arm64' specified for 'TargetPlatform'.

This is because TargetPlatform is Architecture enum and that enum does not have arm64. There is also PlatformArchitecture and IsPlatformIncompatible and other few places that possible need update, not just the enum value.

Can be unblocked by not using that option in settings, but it should work correctly.

@am11
Copy link

am11 commented Sep 14, 2020

With the upcoming MIPS64 architecture (dotnet/runtime#42194, and in future there will be more arch/platforms supported by the runtime); if possible, imo it would scale well if the internal/hardcoded enum dependency is shifted to the executing runtime's API for such information.

@ViktorHofer
Copy link
Member

+100

@safern
Copy link
Member

safern commented Nov 15, 2021

@MarcoRossignoli @nohwnd do we know what version of VS/dotnet CLI will include this support?

@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Nov 16, 2021

@safern it will be supported on 17.1 for the Microsoft.NET.Test.Sdk sdk it's in preview for test host it https://www.nuget.org/packages/Microsoft.NET.Test.Sdk/17.1.0-preview-20211109-03 and will be supported in 6.0.2 and 7.0.

@safern
Copy link
Member

safern commented Nov 16, 2021

Thanks for the info, @MarcoRossignoli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants