Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MIPS64 RID #42194

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Implement MIPS64 RID #42194

merged 1 commit into from
Sep 14, 2020

Conversation

xiangzhai
Copy link
Contributor

gsvm/loongson-dotnet#6

\cc @jkotas @am11

Thanks,
Leslie Zhai

@am11
Copy link
Member

am11 commented Sep 14, 2020

[this can be done separately]
Do we also need the distro support for MIPS architecture? Note that with distros support, we get (an additional) ability to target distro-specific packages or configurations; as in, it will not affect the ability to build the portable product for linux-mips64, it will only help support the scenarios which care about distros (e.g. NuGet packages sometimes target special version of package for particular distro and RID resolver knows how to find the best match, based on these graphs).

cc @ericstj

@xiangzhai
Copy link
Contributor Author

Do we also need the distro support for MIPS architecture?

\cc @theaoqi

@xiangzhai
Copy link
Contributor Author

runtime Failing after 190m — Build #20200914.3 failed

False positive?

@ghost
Copy link

ghost commented Sep 14, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas requested a review from ericstj September 14, 2020 14:53
@jkotas
Copy link
Member

jkotas commented Sep 14, 2020

Related to #38069

@ericstj ericstj requested a review from wfurt September 14, 2020 15:59
@jkotas jkotas merged commit cfb2ea4 into dotnet:master Sep 14, 2020
@am11 am11 mentioned this pull request Sep 14, 2020
Closed
@xiangzhai xiangzhai deleted the mips64-rid branch September 15, 2020 08:12
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj ericstj approved these changes

@wfurt wfurt Awaiting requested review from wfurt

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiangzhai @am11 @jkotas @ericstj @Dotnet-GitSync-Bot