Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup windows specific code for net46 #820

Closed
singhsarab opened this issue May 17, 2017 · 2 comments
Closed

Cleanup windows specific code for net46 #820

singhsarab opened this issue May 17, 2017 · 2 comments

Comments

@singhsarab
Copy link
Contributor

Description

There is bunch of code for Net46 that is specific to windows. It should be made platform neutral.

  1. https://github.com/Microsoft/vstest/blob/master/src/Microsoft.TestPlatform.ObjectModel/Navigation/DiaSession.cs#L50
  2. https://github.com/Microsoft/vstest/blob/master/src/Microsoft.TestPlatform.ObjectModel/Utilities/XmlRunSettingsUtilities.cs#L44
  3. https://github.com/Microsoft/vstest/blob/master/src/Microsoft.TestPlatform.CoreUtilities/Helpers/DotnetHostHelper.cs#L45

Environment

OS: MAC, Framework: Net46
@yaakov-h
Copy link

For #3, shouldn't we use System.IO.Path.PathSeparator?

codito pushed a commit to codito/vstest that referenced this issue Jun 12, 2017
Add platform abstraction for OS name and architecture.
9013447 
Related microsoft#820 microsoft#679
@codito codito mentioned this issue Jun 12, 2017
Merged
@codito
Copy link
Contributor

codito commented Jun 12, 2017

@yaakov-h 👍 fixed in #851

codito added a commit that referenced this issue Jun 20, 2017
@codito
Add platform abstraction for OS name and architecture. (#851)
bf43157 
* Add platform abstraction for OS name and architecture.

Related #820 #679

* Fix build failures due to incorrect references.

* Publish projects for net46 if mono is available.

* Fix typo in build script.

* Support for mono in multitargeted tests.

Choose mono as launcher for net46 tests if the launcher for vstest.console
is not mono (e.g. dotnet test).
@codito codito closed this as completed Jun 20, 2017
codito added a commit to codito/vstest that referenced this issue Jun 30, 2017
@codito
Add platform abstraction for OS name and architecture. (microsoft#851)
342a098 
* Add platform abstraction for OS name and architecture.

Related microsoft#820 microsoft#679

* Fix build failures due to incorrect references.

* Publish projects for net46 if mono is available.

* Fix typo in build script.

* Support for mono in multitargeted tests.

Choose mono as launcher for net46 tests if the launcher for vstest.console
is not mono (e.g. dotnet test).
codito added a commit that referenced this issue Jul 3, 2017
@codito
Mono support for net46 tests (#904)
634999c 
* Add platform abstraction for OS name and architecture. (#851)

* Add platform abstraction for OS name and architecture.

Related #820 #679

* Fix build failures due to incorrect references.

* Publish projects for net46 if mono is available.

* Fix typo in build script.

* Support for mono in multitargeted tests.

Choose mono as launcher for net46 tests if the launcher for vstest.console
is not mono (e.g. dotnet test).

* Fix build script merge error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codito @yaakov-h @singhsarab