Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary binding redirects from app.configs #1117

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Remove unnecessary binding redirects from app.configs #1117

merged 2 commits into from
Sep 22, 2017

Conversation

smadala
Copy link
Contributor

@smadala smadala commented Sep 20, 2017

  • Removing Newtonsoft.Json binding redirects for vstest.console assembly.
  • Having binding redirect for Newtonsoft.Json causing tests to fail when running in inproc and test source has dependency on Newtonsoft.Json.

@smadala
Copy link
Contributor Author

smadala commented Sep 22, 2017

@dotnet-bot Please test Windows_NT / Release Build .

@smadala smadala merged commit 748ed5e into microsoft:master Sep 22, 2017
@smadala smadala deleted the vstest-redirects branch May 23, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faizan2304 Faizan2304 Faizan2304 approved these changes

@singhsarab singhsarab singhsarab approved these changes

@codito codito codito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smadala @codito @singhsarab @Faizan2304 @msftclas