Adding Category to Test Category mapping for ListFullyQualifiedTests #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot please test Windows_NT / Release Build |
1 similar comment
|
@dotnet-bot please test Windows_NT / Release Build |
acesiddhu
approved these changes
Jan 9, 2018
| @@ -436,6 +437,13 @@ private static List<TestCase> GetFilteredTestCases(IEnumerable<TestCase> testCas | |||
| } | |||
| } | |||
|
|
|||
| //This is hack for NUnit,Xunit to understand test category -> This method is called only for NUnit/Xunit | |||
| if (!traitDictionary.ContainsKey(TestCategory) && traitDictionary.ContainsKey(Category)) | |||
There was a problem hiding this comment.
did we test TIA with this change
prawalagarwal
approved these changes
Jan 9, 2018
|
Can this switch |
|
@JunielKatarn No this cannot be used without an output file. This flag was introduced for a very specific purpose and we needed it to output to a file back then. |
|
@pranavkm How can I run tests in a binary, showing their fully qualified name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ListFullyQualifiedTests doesn't filter tests based on TestCategory for Nunit/Xunit adapters