Cleaning the remaining set of dependencies for source build. #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a. Microsoft.Build.Framework and Microsoft.Build.Utilities.Core to source built version: 16.0.461 b. Microsoft.Extensions.DependencyModel to source built version: 3.0.0-preview4-27615-11 c. Removed the redundant reference to Microsoft.Internal.Dia.Interop d. Adding check for source build for StyleCop.Analyzers
|
|
||
| <!-- Add localized resources --> | ||
| <file src="Microsoft.TestPlatform.Build\netstandard1.3\**\*.dll" target="lib\netstandard1.3" /> | ||
| <file src="Microsoft.TestPlatform.Build\netstandard2.0\**\*.dll" target="lib\netstandard2.0" /> |
There was a problem hiding this comment.
We need to check how is Tp.build package is inserted in CLI, if they are unzipping, & then copying from ns1.3 folder explicitly, this would fail now
| @@ -17,7 +17,7 @@ | |||
| <group targetFramework="netcoreapp1.0"> | |||
| <dependency id="Microsoft.TestPlatform.ObjectModel" version="$Version$"/> | |||
| <dependency id="Newtonsoft.Json" version="$JsonNetVersion$"/> | |||
| <dependency id="Microsoft.Extensions.DependencyModel" version="1.0.3"/> | |||
| <dependency id="Microsoft.Extensions.DependencyModel" version="3.0.0-preview4-27615-11"/> | |||
There was a problem hiding this comment.
Make this parameterized as we do for JsonNetVersion
There was a problem hiding this comment.
This can be removed from Test Host nuspec.
mayankbansal018
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a. Microsoft.Build.Framework and Microsoft.Build.Utilities.Core to source built version: 16.0.461
b. Microsoft.Extensions.DependencyModel to source built version: 3.0.0-preview4-27615-11
c. Removed the redundant reference to Microsoft.Internal.Dia.Interop
d. Adding check for source build for StyleCop.Analyzers
Related issue
dotnet/source-build#896