for #2120 DisableProgress when environment CI true #2125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davidruhmann
commented
Aug 9, 2019
| @@ -219,10 +221,19 @@ public void Initialize(TestLoggerEvents events, Dictionary<string, string> param | |||
| bool.TryParse(prefix, out AppendPrefix); | |||
| } | |||
|
|
|||
| var ciEnvironment = Environment.GetEnvironmentVariable(ConsoleLogger.ContinuousIntegrationIndicator); | |||
| if (bool.TryParse(ciEnvironment, out var ci) && ci) | |||
There was a problem hiding this comment.
currently only checking if true or false case insensitive. should additional values be accepted? 1/0?
|
We are trying to get to the bottom of this issue. To see why the progress indicator is slowing execution down. @singhsarab to provide updates here. |
|
This is not longer required, changed the default behavior not to show the progress indicator. #2234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable the progress when CI environment variable is true to mitigate performance issue when running tests on detached hosts and verbosity normal or greater.
Related issue
Fixes #2120 , #2106