Remove duplicate counting of test results in Consolelogger #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Dec 10, 2019
singhsarab
reviewed
Dec 10, 2019
nohwnd
reviewed
Dec 31, 2019
| var executionId = GetExecutionId(e.Result); | ||
| var parentExecutionId = GetParentExecutionId(e.Result); | ||
|
|
||
| if (parentExecutionId != null && leafExecutionIdAndTestOutcomePairDictionary.ContainsKey(parentExecutionId)) |
There was a problem hiding this comment.
@hvinett GetParentExecutionId returns non-nullable guid, removing the nullability check, as well as replacing it with != Guid.Empty check passes all the tests in ConsoleLoggerTests what is the intent here?
There was a problem hiding this comment.
I kept parentExecutionId != null, because .containskey() throws error if key is null. As it is not null we can check parentExecutionId != Guid.Empty to avoid check in dictionary. Is that fine?
There was a problem hiding this comment.
Yup. Let me quickly patch that, because I have the code open, and merge if that passes (it should, I tried it before).
singhsarab
reviewed
Jan 2, 2020
nohwnd
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current behavior:
Recognizing parent result as passed ,failed or skipped and adding to respective counts.By this we are showing duplicate count.
ex:
Scenario:
if we have a parent test result(passed) and two child test results in which one is passed and the other is failed.
current behavior:
total test =3
passed tests =1
Failed =2
expected behavior:
total tests =2
passed tests =1
failed tests =1
Approach :
Storing every result and it's outcome in dictionary. if it is recognized as parent then removing it from dictionary. By this way we end up with the dictionary that has non parent results and it's outcome. Finally counting the passed,failed, skipped and total in the resulting dictionary will give the expected behavior mentioned above
Assumed parent test result comes first and then the child test result comes.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.