Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patched version of Internal.TestPlatform.Extensions #2283

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Dec 31, 2019

Description

A quick fix for updating Microsoft.Internal.TestPlatform.Extensions that is coming from VS build, the version of the package is tied to all other external packages. The easiest approach to do this is to publish a patched version on myget and change the build script.

This allows updating just a single binary in the package without updating all the other external dependencies.

And avoids hardcoding the version number for just the single package because then we would have to remember it for the next time we update it.

The current package on myget contains non-signed dll at the moment.

Related issue

None

@nohwnd
Copy link
Member Author

nohwnd commented Jan 6, 2020

This is still waiting for the signed binary which can't be delivered till build outage is solved.

@nohwnd nohwnd merged commit 3ae0859 into microsoft:master Jan 10, 2020
@nohwnd nohwnd deleted the patch-external-dependency branch January 10, 2020 13:21
nohwnd added a commit that referenced this pull request Jan 16, 2020
nohwnd added a commit that referenced this pull request Jan 16, 2020
nohwnd added a commit that referenced this pull request Feb 3, 2020
* Use patched version of TestPlatform.Extensions (#2283)

* Use another patched version of TraceDataCollector

* Bump up patched nuget version to avoid caching issues
@nohwnd nohwnd restored the patch-external-dependency branch August 15, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants