-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass coverlet codebase in runsettings for inproc data collector initialization #2288
Pass coverlet codebase in runsettings for inproc data collector initialization #2288
Conversation
Checking failure. |
Ready to review. |
test/Microsoft.TestPlatform.Common.UnitTests/ExtensionFramework/TestPluginCacheTests.cs
Show resolved
Hide resolved
Did some manual tests
|
Checking failures, on my local some smoke/acceptance fails also on master(for some reason I don't understand yet) so I use CI to find real one. |
@AbhitejJohn @nohwnd can you review? I moved to init and also switched two priority because After this merge could be great a new preview release so I can add some integration test on coverlet side to be sure that collector will be loaded. |
Any news? |
@MarcoRossignoli : Sorry I couldn't get to this earlier. This looks good to me. |
closes #2275
cc: @vagisha-nidhi @AbhitejJohn @singhsarab
If after merge you can deploy a preview package I can try to test with our new integration tests https://github.com/tonerdo/coverlet/blob/master/test/coverlet.integration.tests/Collectors.cs
I know we cannot test runner but only host, btw I'll run with my local patched sdk for the acceptance test.