Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch arguments for expected and actual in Assert.AreEquals in multiple tests #2329

Merged
merged 13 commits into from
Feb 24, 2020

Conversation

HeroMaxPower
Copy link
Contributor

Description

This PR is to fix some asserts in the TestPlatform.sln solution, the expected and actual are round the wrong way.

e.g.

Assert.AreEqual(aggregator.RunContextAttachments.Count, 1, "RunContextAttachments List must have data.");

should be

Assert.AreEqual(1, aggregator.RunContextAttachments.Count, "RunContextAttachments List must have data.");

Related issue

Fixes #2328

@msftclas
Copy link

msftclas commented Feb 14, 2020

CLA assistant check
All CLA requirements met.

@HeroMaxPower HeroMaxPower requested a review from nohwnd February 14, 2020 14:38
@HeroMaxPower
Copy link
Contributor Author

I think i got all of them, i also converted
convert Assert.AreEqual(true, ... to Assert.IsTrue(
convert Assert.AreEqual(false, ... to Assert.IsFalse(
convert Assert.AreEqual(null, ... to Assert.IsNull(

Ready to review.

@nohwnd nohwnd merged commit d24ac02 into microsoft:master Feb 24, 2020
@nohwnd
Copy link
Member

nohwnd commented Feb 24, 2020

Merged, thanks!

@HeroMaxPower HeroMaxPower deleted the fix-assert-expected-actual-args branch March 3, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Asserts.AreEqual in TestPlatform.sln have incorrect expected and actual arguments.
3 participants