Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change indicators to words #2475

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Change indicators to words #2475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions src/vstest.console/Internal/ConsoleLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,21 +36,6 @@ internal class ConsoleLogger : ITestLoggerWithParameters
/// </summary>
private const string TestResultPrefix = " ";

/// <summary>
/// Unicode for tick
/// </summary>
private const char PassedTestIndicator = '\u221a';

/// <summary>
/// Indicator for failed tests
/// </summary>
private const char FailedTestIndicator = 'X';

/// <summary>
/// Indicated skipped and not run tests
/// </summary>
private const char SkippedTestIndicator = '!';

/// <summary>
/// Bool to decide whether Verbose level should be added as prefix or not in log messages.
/// </summary>
Expand Down Expand Up @@ -544,7 +529,7 @@ private void TestResultHandler(object sender, TestResultEventArgs e)
// Pause the progress indicator before displaying test result information
this.progressIndicator?.Pause();

Output.Write(string.Format("{0}{1} ", TestResultPrefix, SkippedTestIndicator), OutputLevel.Information, ConsoleColor.Yellow);
Output.Write(string.Format("{0}{1} ", TestResultPrefix, CommandLineResources.SkippedTestIndicator), OutputLevel.Information, ConsoleColor.Yellow);
Output.WriteLine(testDisplayName, OutputLevel.Information);
if (this.verbosityLevel == Verbosity.Detailed)
{
Expand All @@ -567,7 +552,7 @@ private void TestResultHandler(object sender, TestResultEventArgs e)
// Pause the progress indicator before displaying test result information
this.progressIndicator?.Pause();

Output.Write(string.Format("{0}{1} ", TestResultPrefix, FailedTestIndicator), OutputLevel.Information, ConsoleColor.Red);
Output.Write(string.Format("{0}{1} ", TestResultPrefix, CommandLineResources.FailedTestIndicator), OutputLevel.Information, ConsoleColor.Red);
Output.WriteLine(testDisplayName, OutputLevel.Information);
DisplayFullInformation(e.Result);

Expand All @@ -584,7 +569,7 @@ private void TestResultHandler(object sender, TestResultEventArgs e)
// Pause the progress indicator before displaying test result information
this.progressIndicator?.Pause();

Output.Write(string.Format("{0}{1} ", TestResultPrefix, PassedTestIndicator), OutputLevel.Information, ConsoleColor.Green);
Output.Write(string.Format("{0}{1} ", TestResultPrefix, CommandLineResources.PassedTestIndicator), OutputLevel.Information, ConsoleColor.Green);
Output.WriteLine(testDisplayName, OutputLevel.Information);
if (this.verbosityLevel == Verbosity.Detailed)
{
Expand All @@ -608,7 +593,7 @@ private void TestResultHandler(object sender, TestResultEventArgs e)
// Pause the progress indicator before displaying test result information
this.progressIndicator?.Pause();

Output.Write(string.Format("{0}{1} ", TestResultPrefix, SkippedTestIndicator), OutputLevel.Information, ConsoleColor.Yellow);
Output.Write(string.Format("{0}{1} ", TestResultPrefix, CommandLineResources.SkippedTestIndicator), OutputLevel.Information, ConsoleColor.Yellow);
Output.WriteLine(testDisplayName, OutputLevel.Information);
if (this.verbosityLevel == Verbosity.Detailed)
{
Expand Down
9 changes: 5 additions & 4 deletions src/vstest.console/Resources/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src/vstest.console/Resources/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@
<value> Uri: {0}</value>
</data>
<data name="FailedTestIndicator" xml:space="preserve">
<value>Failed {0}</value>
<value>Failed</value>
<comment>Message which is written to the console when a test fails.</comment>
</data>
<data name="FileNotFound" xml:space="preserve">
Expand Down Expand Up @@ -436,7 +436,7 @@
Process Id of the Parent Process responsible for launching current process.</value>
</data>
<data name="PassedTestIndicator" xml:space="preserve">
<value>Passed {0}</value>
<value>Passed</value>
<comment>Message which is written to the console when a test passes.</comment>
</data>
<data name="PhoneAppContainerTestPrerequisiteFail" xml:space="preserve">
Expand Down Expand Up @@ -499,7 +499,7 @@
<value> SettingName: {0}</value>
</data>
<data name="SkippedTestIndicator" xml:space="preserve">
<value>Skipped {0}</value>
<value>Skipped</value>
</data>
<data name="SomeTestsUnavailableAfterFiltering" xml:space="preserve">
<value>A total of {0} tests were discovered but some tests do not match the specified selection criteria({1}). Use right value(s) and try again.</value>
Expand Down Expand Up @@ -629,7 +629,7 @@
<value>The /InIsolation flag is deprecated. The tests are always run in a separate process</value>
</data>
<data name="NotRunTestIndicator" xml:space="preserve">
<value>Not Run {0}</value>
<value>Not Run</value>
</data>
<data name="VstestDiagLogOutputPath" xml:space="preserve">
<value>Logging Vstest Diagnostics in file: {0}</value>
Expand Down
20 changes: 10 additions & 10 deletions src/vstest.console/Resources/xlf/Resources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,27 +1304,27 @@
<note from="bb-metadata">fuzzyMatch="15" wordcount="24" adjWordcount="20.4" curWordcount="20.4"</note>
</trans-unit>
<trans-unit id="FailedTestIndicator">
<source>Failed {0}</source>
<target state="translated">Počet neúspěšných: {0}</target>
<source>Failed</source>
<target state="new">Počet neúspěšných: {0}</target>
<note>Message which is written to the console when a test fails.</note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Fehlgeschlagene {0}</target>
</alt-trans>
<note from="bb-metadata">fuzzyMatch="15" wordcount="2" adjWordcount="1.7" curWordcount="1.7"</note>
</trans-unit>
<trans-unit id="PassedTestIndicator">
<source>Passed {0}</source>
<target state="translated">Počet úspěšných: {0}</target>
<source>Passed</source>
<target state="new">Počet úspěšných: {0}</target>
<note>Message which is written to the console when a test passes.</note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Übergebene {0}</target>
</alt-trans>
<note from="bb-metadata">fuzzyMatch="15" wordcount="2" adjWordcount="1.7" curWordcount="1.7"</note>
</trans-unit>
<trans-unit id="SkippedTestIndicator">
<source>Skipped {0}</source>
<target state="translated">Počet přeskočených: {0}</target>
<note />
<source>Skipped</source>
<target state="new">Počet přeskočených: {0}</target>
<note></note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Übersprungene {0}</target>
</alt-trans>
Expand Down Expand Up @@ -1447,9 +1447,9 @@
<note />
</trans-unit>
<trans-unit id="NotRunTestIndicator">
<source>Not Run {0}</source>
<target state="translated">Nespuštěno: {0}</target>
<note />
<source>Not Run</source>
<target state="new">Nespuštěno: {0}</target>
<note></note>
</trans-unit>
<trans-unit id="VstestDiagLogOutputPath">
<source>Logging Vstest Diagnostics in file: {0}</source>
Expand Down
20 changes: 10 additions & 10 deletions src/vstest.console/Resources/xlf/Resources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,27 +1304,27 @@
<note from="bb-metadata">fuzzyMatch="15" wordcount="24" adjWordcount="20.4" curWordcount="20.4"</note>
</trans-unit>
<trans-unit id="FailedTestIndicator">
<source>Failed {0}</source>
<target state="translated">Fehler {0}</target>
<source>Failed</source>
<target state="new">Fehler {0}</target>
<note>Message which is written to the console when a test fails.</note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Fehlgeschlagene {0}</target>
</alt-trans>
<note from="bb-metadata">fuzzyMatch="15" wordcount="2" adjWordcount="1.7" curWordcount="1.7"</note>
</trans-unit>
<trans-unit id="PassedTestIndicator">
<source>Passed {0}</source>
<target state="translated">Bestanden {0}</target>
<source>Passed</source>
<target state="new">Bestanden {0}</target>
<note>Message which is written to the console when a test passes.</note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Übergebene {0}</target>
</alt-trans>
<note from="bb-metadata">fuzzyMatch="15" wordcount="2" adjWordcount="1.7" curWordcount="1.7"</note>
</trans-unit>
<trans-unit id="SkippedTestIndicator">
<source>Skipped {0}</source>
<target state="translated">Übersprungen {0}</target>
<note />
<source>Skipped</source>
<target state="new">Übersprungen {0}</target>
<note></note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Übersprungene {0}</target>
</alt-trans>
Expand Down Expand Up @@ -1447,9 +1447,9 @@
<note />
</trans-unit>
<trans-unit id="NotRunTestIndicator">
<source>Not Run {0}</source>
<target state="translated">Nicht ausgeführt: {0}</target>
<note />
<source>Not Run</source>
<target state="new">Nicht ausgeführt: {0}</target>
<note></note>
</trans-unit>
<trans-unit id="VstestDiagLogOutputPath">
<source>Logging Vstest Diagnostics in file: {0}</source>
Expand Down
20 changes: 10 additions & 10 deletions src/vstest.console/Resources/xlf/Resources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,27 +1307,27 @@
<note from="bb-metadata">fuzzyMatch="15" wordcount="24" adjWordcount="20.4" curWordcount="20.4"</note>
</trans-unit>
<trans-unit id="FailedTestIndicator">
<source>Failed {0}</source>
<target state="translated">Con error {0}</target>
<source>Failed</source>
<target state="new">Con error {0}</target>
<note>Message which is written to the console when a test fails.</note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Fehlgeschlagene {0}</target>
</alt-trans>
<note from="bb-metadata">fuzzyMatch="15" wordcount="2" adjWordcount="1.7" curWordcount="1.7"</note>
</trans-unit>
<trans-unit id="PassedTestIndicator">
<source>Passed {0}</source>
<target state="translated">Correctas {0}</target>
<source>Passed</source>
<target state="new">Correctas {0}</target>
<note>Message which is written to the console when a test passes.</note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Übergebene {0}</target>
</alt-trans>
<note from="bb-metadata">fuzzyMatch="15" wordcount="2" adjWordcount="1.7" curWordcount="1.7"</note>
</trans-unit>
<trans-unit id="SkippedTestIndicator">
<source>Skipped {0}</source>
<target state="translated">Omitidas {0}</target>
<note />
<source>Skipped</source>
<target state="new">Omitidas {0}</target>
<note></note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Übersprungene {0}</target>
</alt-trans>
Expand Down Expand Up @@ -1450,9 +1450,9 @@
<note />
</trans-unit>
<trans-unit id="NotRunTestIndicator">
<source>Not Run {0}</source>
<target state="translated">No ejecutar {0}</target>
<note />
<source>Not Run</source>
<target state="new">No ejecutar {0}</target>
<note></note>
</trans-unit>
<trans-unit id="VstestDiagLogOutputPath">
<source>Logging Vstest Diagnostics in file: {0}</source>
Expand Down
20 changes: 10 additions & 10 deletions src/vstest.console/Resources/xlf/Resources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,27 +1304,27 @@
<note from="bb-metadata">fuzzyMatch="15" wordcount="24" adjWordcount="20.4" curWordcount="20.4"</note>
</trans-unit>
<trans-unit id="FailedTestIndicator">
<source>Failed {0}</source>
<target state="translated">Non réussi(s) : {0}</target>
<source>Failed</source>
<target state="new">Non réussi(s) : {0}</target>
<note>Message which is written to the console when a test fails.</note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Fehlgeschlagene {0}</target>
</alt-trans>
<note from="bb-metadata">fuzzyMatch="15" wordcount="2" adjWordcount="1.7" curWordcount="1.7"</note>
</trans-unit>
<trans-unit id="PassedTestIndicator">
<source>Passed {0}</source>
<target state="translated">Réussi(s) : {0}</target>
<source>Passed</source>
<target state="new">Réussi(s) : {0}</target>
<note>Message which is written to the console when a test passes.</note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Übergebene {0}</target>
</alt-trans>
<note from="bb-metadata">fuzzyMatch="15" wordcount="2" adjWordcount="1.7" curWordcount="1.7"</note>
</trans-unit>
<trans-unit id="SkippedTestIndicator">
<source>Skipped {0}</source>
<target state="translated">Ignoré(s) : {0}</target>
<note />
<source>Skipped</source>
<target state="new">Ignoré(s) : {0}</target>
<note></note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Übersprungene {0}</target>
</alt-trans>
Expand Down Expand Up @@ -1447,9 +1447,9 @@
<note />
</trans-unit>
<trans-unit id="NotRunTestIndicator">
<source>Not Run {0}</source>
<target state="translated">{0} non exécuté</target>
<note />
<source>Not Run</source>
<target state="new">{0} non exécuté</target>
<note></note>
</trans-unit>
<trans-unit id="VstestDiagLogOutputPath">
<source>Logging Vstest Diagnostics in file: {0}</source>
Expand Down
20 changes: 10 additions & 10 deletions src/vstest.console/Resources/xlf/Resources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,27 +1304,27 @@
<note from="bb-metadata">fuzzyMatch="15" wordcount="24" adjWordcount="20.4" curWordcount="20.4"</note>
</trans-unit>
<trans-unit id="FailedTestIndicator">
<source>Failed {0}</source>
<target state="translated">Non superato {0}</target>
<source>Failed</source>
<target state="new">Non superato {0}</target>
<note>Message which is written to the console when a test fails.</note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Fehlgeschlagene {0}</target>
</alt-trans>
<note from="bb-metadata">fuzzyMatch="15" wordcount="2" adjWordcount="1.7" curWordcount="1.7"</note>
</trans-unit>
<trans-unit id="PassedTestIndicator">
<source>Passed {0}</source>
<target state="translated">Superato {0}</target>
<source>Passed</source>
<target state="new">Superato {0}</target>
<note>Message which is written to the console when a test passes.</note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Übergebene {0}</target>
</alt-trans>
<note from="bb-metadata">fuzzyMatch="15" wordcount="2" adjWordcount="1.7" curWordcount="1.7"</note>
</trans-unit>
<trans-unit id="SkippedTestIndicator">
<source>Skipped {0}</source>
<target state="translated">Ignorato {0}</target>
<note />
<source>Skipped</source>
<target state="new">Ignorato {0}</target>
<note></note>
<alt-trans match-quality="100%" tool="BlackBox/MSR MT">
<target state-qualifier="mt-suggestion">Übersprungene {0}</target>
</alt-trans>
Expand Down Expand Up @@ -1447,9 +1447,9 @@
<note />
</trans-unit>
<trans-unit id="NotRunTestIndicator">
<source>Not Run {0}</source>
<target state="translated">Non eseguiti: {0}</target>
<note />
<source>Not Run</source>
<target state="new">Non eseguiti: {0}</target>
<note></note>
</trans-unit>
<trans-unit id="VstestDiagLogOutputPath">
<source>Logging Vstest Diagnostics in file: {0}</source>
Expand Down
Loading