-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed code coverage compatibility issue #2514
Fixed code coverage compatibility issue #2514
Conversation
@@ -112,8 +112,7 @@ public string GetSessionName() | |||
|
|||
try | |||
{ | |||
var processor = new CodeCoverageRunSettingsProcessor(defaultConfigurationElement); | |||
configurationElement = (XmlElement)processor.Process(configurationElement); | |||
configurationElement = this.RunSettingsProcessor(configurationElement, defaultConfigurationElement); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets have method AddDefaultExclusions
with content:
var processor = new CodeCoverageRunSettingsProcessor(defaultConfigurationElement);
configurationElement = (XmlElement)processor.Process(configurationElement);
Could you please add comment to this function with explanation why we are adding it.
I want to make sure that nobody will remove it :)
Hello @cvpoienaru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
* Fixed code coverage compatibility issue * Added comment * Updated commit
I believe this regression has shown up again with the push of either this PR Or the one Prior (16.7.0) We create a win 64 build of our dotnet core 3.1 project. Azure Dev Ops agents are reporting 16.7.0 is installed.
Reverting back to 16.2.0 via nuget is allowing the tests to be run again while 16.7.0 is identifying itself as the CLI tool. Behavior started today 8/26/2020 using ADO requested image of windows-latest.
Run Settings contents File: Error coming in using 16.6.1, 16.7.0, and 16.7.1 Nuget packages with the ADO 16.7.0 Test Command line tool A total of 1 test files matched the specified pattern.
|
@cvpoienaru please have a look. |
Description
Fixed code coverage compatibility issue