TestPluginCache and other dependencies refactoring #2537

Sanan07 · 2020-08-25T12:14:34Z

Description

Refactoring of TestPluginCache and other classes responsible for test discovery and test execution

Fix : #2634

…ng to create TestResults folder

…r path in that message

…ssemblies

… be loaded from that assembly.Removed unnecessary FileHelper instance.

Sanan07 · 2020-10-07T10:05:51Z

/azp run

azure-pipelines · 2020-10-07T10:05:56Z

No pipelines are associated with this pull request.

Sanan07 · 2020-10-07T12:09:18Z

/azp run

azure-pipelines · 2020-10-07T12:09:30Z

Azure Pipelines successfully started running 1 pipeline(s).

Sanan07 · 2020-10-07T13:03:00Z

/azp run

azure-pipelines · 2020-10-07T13:03:18Z

Azure Pipelines successfully started running 1 pipeline(s).

… in CI

…/sayuzbas/test-plugin-cache

Sanan07 · 2020-10-08T16:13:59Z

/azp run

azure-pipelines · 2020-10-08T16:14:04Z

No pipelines are associated with this pull request.

src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Properties/AssemblyInfo.cs

…icrosoft/vstest into dev/sayuzbas/test-plugin-cache

Sanan07 · 2020-10-14T22:54:52Z

/azp run

azure-pipelines · 2020-10-14T22:55:04Z

Azure Pipelines successfully started running 1 pipeline(s).

…topwatch

…/sayuzbas/test-plugin-cache

nohwnd

Do we have some measurements on this? I would like to see it do it's magic. How much time should this save? And how to best test it?

src/Microsoft.TestPlatform.Common/ExtensionFramework/TestPluginDiscoverer.cs

src/Microsoft.TestPlatform.ObjectModel/Utilities/TypesToLoadAttribute.cs

Sanan07 · 2020-11-13T15:10:15Z

@nohwnd Do you mean measurements of using custom attributes? If assembly has custom attributes, on average it takes 1.5-2ms to get that "interesting" types, compared to 30ms which takes calling GetTypes() method on assembly. So having that custom attributes on several assemblies (for now 5 assemblies and will add to MSTestAdapter as well) can save us around ~170 - 200ms.

nohwnd · 2020-11-13T15:49:02Z

Yeah, just wanted the benefit to be documented here for future reference. :)

…/sayuzbas/test-plugin-cache

Haplois

Looks good, but I have a nit-picking comment.

Haplois · 2020-11-19T16:24:08Z

src/Microsoft.TestPlatform.ObjectModel/Utilities/TypesToLoadAttribute.cs

@@ -18,6 +17,6 @@ public TypesToLoadAttribute(params Type[] types)
            Types = types;
        }

-        public IEnumerable<Type> Types { get; }
+        public Type[] Types { get; }


This is no longer immutable.

IEnumerable, is also not immutable isn't it? But does it matter? How would this collection change to cause problems? We would need a static ctor to find it and modify it on assembly load?

Sanan07 added 20 commits May 26, 2020 12:32

Test space added

4eb1f76

Exception handler was added to catch AccessDeniedException while tryi…

fd6cbbf

…ng to create TestResults folder

Remove unnecessary space

026226a

Deleted unnecessary test. Changed console message and corrected folde…

104ffc0

…r path in that message

Remove unnecessary dot

2608e88

Removed unnecessary lines and usings and coreccted exception message

f8d8aa1

Removed unnecessary line

0f6bf18

Updating resource files

d1803c9

New exception handling was added

bf0cacf

Merge branch 'master' into accessDeniedException

3ee2dc7

Formatted exception message

2582e75

Merge branch 'accessDeniedException'

030fda6

Merge branch 'master' of https://github.com/microsoft/vstest

ea180c3

Merge branch 'master' of https://github.com/microsoft/vstest

7a896ff

Merge branch 'master' of https://github.com/microsoft/vstest

8ea1932

Merge branch 'master' of https://github.com/microsoft/vstest

740ae68

Small improvements in TestPluginDiscoverer about loading types from a…

73e626f

…ssemblies

Small performance improvements

c0b9e3d

TestExtensions - refactored typeof operations

2c40e69

Added new assembly level attribute to define excat types which should…

a76ee21

… be loaded from that assembly.Removed unnecessary FileHelper instance.

Sanan07 added 4 commits October 7, 2020 15:12

Commenting piece of code which cause build error

efcfb64

Restored previous implementation

6512ee6

Changed methods because previous changes had exception while building…

e7839bd

… in CI

Merge branch 'master' of https://github.com/microsoft/vstest into dev…

61622b4

…/sayuzbas/test-plugin-cache

Added missing attribute to blame, event collector and code coverage

51ced2e

nohwnd reviewed Oct 8, 2020

View reviewed changes

src/Microsoft.TestPlatform.Extensions.BlameDataCollector/Properties/AssemblyInfo.cs Outdated Show resolved Hide resolved

Sanan07 added 2 commits October 14, 2020 14:16

Merge branch 'dev/sayuzbas/test-plugin-cache' of https://github.com/m…

e130cdd

…icrosoft/vstest into dev/sayuzbas/test-plugin-cache

Redesigned custom attribute to specify interesting types themselves

6170b27

Sanan07 added 7 commits October 15, 2020 01:47

More improvements

3c89fb9

Fixed cast exception

f72333b

GetTypes returned to previous implementation and removed unncessary S…

e60aea5

…topwatch

changed global.json

e9c3ccc

returned to previous version in global.json

3309572

Merge branch 'master' of https://github.com/microsoft/vstest into dev…

0bfaa31

…/sayuzbas/test-plugin-cache

Merge branch 'master' of https://github.com/microsoft/vstest into dev…

ef7d60f

…/sayuzbas/test-plugin-cache

Sanan07 self-assigned this Nov 9, 2020

Sanan07 marked this pull request as ready for review November 9, 2020 15:59

nohwnd reviewed Nov 13, 2020

View reviewed changes

src/Microsoft.TestPlatform.Common/ExtensionFramework/TestPluginDiscoverer.cs Outdated Show resolved Hide resolved

src/Microsoft.TestPlatform.ObjectModel/Utilities/TypesToLoadAttribute.cs Outdated Show resolved Hide resolved

Sanan07 added 2 commits November 19, 2020 14:45

PR review fix

e081c3f

Merge branch 'master' of https://github.com/microsoft/vstest into dev…

20655e7

…/sayuzbas/test-plugin-cache

Sanan07 requested review from cvpoienaru and Haplois November 19, 2020 14:01

Haplois approved these changes Nov 19, 2020

View reviewed changes

Sanan07 merged commit 67689ab into microsoft:master Nov 19, 2020

This was referenced Dec 14, 2020

Removed TypesToLoadAttribute from ObjectModel. #2674

Merged

Fixed TypesToLoadAttribute compatibility microsoft/testfx#753

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TestPluginCache and other dependencies refactoring #2537

TestPluginCache and other dependencies refactoring #2537

Sanan07 commented Aug 25, 2020 •

edited

Loading

Sanan07 commented Oct 7, 2020

azure-pipelines bot commented Oct 7, 2020

Sanan07 commented Oct 7, 2020

azure-pipelines bot commented Oct 7, 2020

Sanan07 commented Oct 7, 2020

azure-pipelines bot commented Oct 7, 2020

Sanan07 commented Oct 8, 2020

azure-pipelines bot commented Oct 8, 2020

Sanan07 commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

nohwnd left a comment

Sanan07 commented Nov 13, 2020

nohwnd commented Nov 13, 2020

Haplois left a comment

Haplois Nov 19, 2020

nohwnd Nov 30, 2020

TestPluginCache and other dependencies refactoring #2537

TestPluginCache and other dependencies refactoring #2537

Conversation

Sanan07 commented Aug 25, 2020 • edited Loading

Description

Sanan07 commented Oct 7, 2020

azure-pipelines bot commented Oct 7, 2020

Sanan07 commented Oct 7, 2020

azure-pipelines bot commented Oct 7, 2020

Sanan07 commented Oct 7, 2020

azure-pipelines bot commented Oct 7, 2020

Sanan07 commented Oct 8, 2020

azure-pipelines bot commented Oct 8, 2020

Sanan07 commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

nohwnd left a comment

Choose a reason for hiding this comment

Sanan07 commented Nov 13, 2020

nohwnd commented Nov 13, 2020

Haplois left a comment

Choose a reason for hiding this comment

Haplois Nov 19, 2020

Choose a reason for hiding this comment

nohwnd Nov 30, 2020

Choose a reason for hiding this comment

Sanan07 commented Aug 25, 2020 •

edited

Loading