-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed TestCase Properties implemented #2611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haplois
force-pushed
the
fqn
branch
3 times, most recently
from
November 2, 2020 09:13
593aae8
to
ce6ea34
Compare
Haplois
changed the title
Managed TestCase Properties implemented
Nov 2, 2020
ManagedType
and ManagedMethod
support added
Haplois
force-pushed
the
fqn
branch
2 times, most recently
from
November 2, 2020 09:34
0f8f17d
to
51a982b
Compare
* `ManagedType` and `ManagedMethod` support added to `Microsoft.TestPlatform.ObjectModel.TestCase`
peterwald
reviewed
Nov 3, 2020
peterwald
reviewed
Nov 3, 2020
In general this looks good to me. A couple of overall comments in addition to the inline ones....
|
peterwald
approved these changes
Nov 3, 2020
Haplois
force-pushed
the
fqn
branch
3 times, most recently
from
November 5, 2020 17:59
502bc30
to
b50bf89
Compare
Haplois
force-pushed
the
fqn
branch
2 times, most recently
from
November 15, 2020 22:38
3528015
to
8bcca4e
Compare
Haplois
force-pushed
the
fqn
branch
4 times, most recently
from
November 19, 2020 09:22
02fa4b4
to
e04f770
Compare
Hello @Haplois! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
nohwnd
reviewed
Nov 19, 2020
Looks good :) |
6 tasks
4 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented https://github.com/microsoft/vstest-docs/blob/master/RFCs/0017-Managed-TestCase-Properties.md