Generation of CodeCoverage.deps.json file #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanan07
approved these changes
Nov 12, 2020
| @@ -67,6 +67,14 @@ public void GetVanguardProfilerConfigX64PathShouldReturnRightDirectory() | |||
| Assert.AreEqual(Path.Join(this.GetCurrentAssemblyLocation(), @"CodeCoverage\amd64\VanguardInstrumentationProfiler_x64.config"), actualPath); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void GetCodeCoverageShimPathShouldReturnRightDirectory() | |||
There was a problem hiding this comment.
Prefer to rename to GetCodeCoverageShimPathShouldReturnCorrectDirectory
| /// <summary> | ||
| /// Name of element for custom coverage filename. | ||
| /// </summary> | ||
| private const string CoverageFileSettingName = "CoverageFileName"; | ||
|
|
||
| private const string CodeCoverageDepsJsonTemplate = @" | ||
| {{ |
There was a problem hiding this comment.
Will this work in different platforms? Is it better to concatenate strings with Environment.NewLine?
There was a problem hiding this comment.
logic is invoked only on windows now, new lines doesn't matter for JSON files
|
|
||
| var obj = JObject.Parse(File.ReadAllText(this.collectorImpl.CodeCoverageDepsJsonFilePath)); | ||
|
|
||
| var expected = @" |
There was a problem hiding this comment.
Since it's a json file, a new line shouldn't affect anything other than formatting.
There was a problem hiding this comment.
also this stuff is working only on Windows now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added logic to create by TraceDataCollector CodeCoverage.deps.json. This file is used to add reference to Shim dll to any child process from main test project (if verifiable probes are enabled).
Related issue
#1263