Attach to VS automatically #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually no. Build.cmd is generally used, so the build will run in a sub-process, and won't affect the current session. And to set it to user context we need admin, and I don't want to do that. So just add it to your PATH I guess? Or you can run the ./scripts/build.ps1 directly and that sets that environment correctly. |
MarcoRossignoli
approved these changes
Nov 26, 2021
src/AttachVS/AttachVS.csproj
Outdated
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFrameworks>net472</TargetFrameworks> | ||
| <LangVersion>preview</LangVersion> |
There was a problem hiding this comment.
not sure why, but lately pressing format in .csproj totally wrecks the file...
|
It's great, maybe follow-up with docs update |
nohwnd
commented
Nov 26, 2021
cvpoienaru
reviewed
Nov 29, 2021
|
|
||
| return isVs; | ||
| } | ||
| catch |
There was a problem hiding this comment.
Why would the above try block throw anything ? Looks like we're only doing a string comparison in there and some tracing and we made sure to check process is not null first.
There was a problem hiding this comment.
You are right. It's probably pointless now.
Elanis
pushed a commit
to Elanis/portfolio
that referenced
this pull request
Dec 13, 2022
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.0.0 to 17.1.0. <details> <summary>Release notes</summary> *Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases).* > ## v17.1.0 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/main/docs/releases.md#1710). > > ## v17.1.0-release-20220113-05 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1710-release-20220113-05). > > ## v17.1.0-preview-20211130-02 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1710-preview-20211130-02). > > ## v17.1.0-preview-20211109-03 > See the release notes [here](https://github.com/microsoft/vstest-docs/blob/master/docs/releases.md#1710-preview-20211109-03). </details> <details> <summary>Commits</summary> - [`fcc0e3a`](microsoft/vstest@fcc0e3a) Added support for TestAdapterLoadingStrategy. ([#3374](microsoft/vstest#3374)) - [`d3c6439`](microsoft/vstest@d3c6439) Fix architecture retrival ([#3251](microsoft/vstest#3251)) - [`4d9f0fb`](microsoft/vstest@4d9f0fb) [rel/17.1] Update dependencies from devdiv/DevDiv/vs-code-coverage ([#3221](microsoft/vstest#3221)) - [`d72bcfa`](microsoft/vstest@d72bcfa) [rel/17.1] Update dependencies from devdiv/DevDiv/vs-code-coverage ([#3216](microsoft/vstest#3216)) - [`c9489b4`](microsoft/vstest@c9489b4) External dependencies updated ([#3204](microsoft/vstest#3204)) - [`e90972e`](microsoft/vstest@e90972e) [main] Update dependencies from dotnet/arcade devdiv/DevDiv/vs-code-coverage ... - [`9cf8a92`](microsoft/vstest@9cf8a92) AttachVS PR comments fixed ([#3201](microsoft/vstest#3201)) - [`8b41e37`](microsoft/vstest@8b41e37) Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov... - [`83de0ad`](microsoft/vstest@83de0ad) Attach to VS automatically ([#3197](microsoft/vstest#3197)) - [`d36b7d8`](microsoft/vstest@d36b7d8) Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-cov... - Additional commits viewable in [compare view](microsoft/vstest@v17.0.0...v17.1.0) </details> <br /> Reviewed-on: https://gitea.dysnomia.studio/elanis/portfolio/pulls/26 Co-authored-by: elanis <elanis@noreply.example.org> Co-committed-by: elanis <elanis@noreply.example.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a tool to attach sub-processes to an instance of Visual Studio, so we can run vstest.console via wrapper and get it attached, or similarly run testhost, and get it automatically attached to VS.
This tool needs to be built as net472, because netcoreapp2.1 and netcoreapp3.1 don't support the used api. So the same executable is re-used for everything. This has the added benefit of not packing it into the nugets we create.
Adds
VSTEST_RUNNER_DEBUG_ATTACHVS,VSTEST_HOST_DEBUG_ATTACHVS,VSTEST_DATACOLLECTOR_DEBUG_ATTACHVSenvironment variables, which take value 0, 1, and<number>.0 disables attaching to VS and is the default, 1 enables it and a parent process of Visual Studio is looked up, or the first Visual Studio that started.
Any number larger than 1 is considered a PID of the process to be inspected, and same logic is used. The current process and all it's parents are checked, and if none of them is VS, then the first VS that started is used. You can use this to define exactly which VS should we attach to.
VSTEST_DEBUG_NOBPis also added to prevent stopping on breakpoints after attaching.The AttachVS tool is located in 3 ways, by looking at
VSTEST_DEBUG_ATTACHVS_PATHenv variable, by searching PATH, and by walking up the directory tree, and looking for special path (this is to locate the tool when you start VS, without and additional env variables). Our build script also adds the correct path to PATH. This allows you to debug both stuff from artifacts, as well as arbitrarydotnet testrun.For general use outside of our repo, put AttachVS to your PATH, or specify
VSTEST_DEBUG_ATTACHVS_PATH.The tool can be observed using DebugView++, logs are written to Trace.