Recognize AnyCPU in case of fallback to PEReader #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
force-pushed
the
fixsdkbuild
branch
from
31c8150 to
d96cb01
Compare
nohwnd
reviewed
Jan 28, 2022
Co-authored-by: Jakub Jareš <me@jakubjares.com>
auto-merge was automatically disabled
January 28, 2022 14:18
Pull Request is not mergeable
MarcoRossignoli
commented
Jan 28, 2022
kasperk81
reviewed
Jan 28, 2022
Evangelink
reviewed
Jan 28, 2022
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
auto-merge was automatically disabled
January 28, 2022 14:56
Pull Request is not mergeable
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Evangelink
approved these changes
Jan 28, 2022
nohwnd
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting 7.0 runtime some
AssemblyNameproperties are deprecated, for instanceProcessorArchitecture.We're relying on it to get the architecture for the dll.
Now it will returns always "None" and we fallback to the PEReader reader, so we need to be able to discover also AnyCPU from it.
I did some manual test with x86/x64/neutral compilation and looks good.
I ran also failing test on the sdk side with the local build and looks good.
Ref issue dotnet/sdk#23597 (comment)